Several of the LTP scripts use /bin/sh, but do not limit themselves to
the features supported by POSIX sh.  For example, on my Ubuntu system,
/bin/sh is a symlink to dash.  I propose the following patch to address
this problem.  There's one bug I haven't been able to track down yet,
but this is an improvement over the current state of affairs.

diff -urp ltp-full-20070831/IDcheck.sh ltp-full-20070831-dash/IDcheck.sh
--- ltp-full-20070831/IDcheck.sh        2007-08-30 04:33:18.000000000 -0400
+++ ltp-full-20070831-dash/IDcheck.sh   2007-09-03 23:45:10.000000000 -0400
@@ -85,7 +85,7 @@ if [ $? != "0" ]; then
 fi
 
 whoami | grep root > /dev/null
-if [ $? == "0" ]; then
+if [ $? = "0" ]; then
  I_AM_ROOT=1
 fi
 
diff -urp ltp-full-20070831/runltp ltp-full-20070831-dash/runltp
--- ltp-full-20070831/runltp    2007-08-30 04:33:28.000000000 -0400
+++ ltp-full-20070831-dash/runltp       2007-09-04 07:32:00.000000000 -0400
@@ -297,7 +297,7 @@ main()
                      ${LTPROOT}/runtest/nptl ${LTPROOT}/runtest/pty \
                      ${LTPROOT}/runtest/containers
         do
-            [ -a "$SCENFILES" ] || \
+            [ -e "$SCENFILES" ] || \
             {
                 echo "FATAL: missing scenario file $SCENFILES"
                 exit 1
@@ -345,7 +345,7 @@ main()
                          ${LTPROOT}/runtest/rpc \
                          ${LTPROOT}/runtest/nfs
         do
-            [ -a "$SCENFILES" ] || \
+            [ -e "$SCENFILES" ] || \
             { 
                 echo "FATAL: missing scenario file $SCENFILES"
                 exit 1
diff -urp ltp-full-20070831/testcases/network/generate.sh 
ltp-full-20070831-dash/testcases/network/generate.sh
--- ltp-full-20070831/testcases/network/generate.sh     2007-08-30 
04:33:26.000000000 -0400
+++ ltp-full-20070831-dash/testcases/network/generate.sh        2007-09-03 
23:43:34.000000000 -0400
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 #
 #   Copyright (c) International Business Machines  Corp., 2001
 #

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to