On Friday 07 September 2007, Matthew Wilcox wrote: > On Fri, Sep 07, 2007 at 10:54:43AM -0400, Mike Frysinger wrote: > > On Friday 07 September 2007, Matthew Wilcox wrote: > > > On Fri, Sep 07, 2007 at 03:33:11AM -0400, Mike Frysinger wrote: > > > > > --- ltp-full-20070831/testcases/network/generate.sh > > > > > -#!/bin/sh > > > > > +#!/bin/bash > > > > > > > > mmm, no ... i wrote that script to be POSIX compliant and everything > > > > used in there is covered by POSIX last i checked, so without any real > > > > information, this hunk is not acceptable > > > > > > The thing that isn't is: > > > > > > 57: while [ $((cnt--)) -gt 0 ] ; do > > > 70: while [ $((cnt--)) -gt 0 ] ; do > > > > that is in POSIX ... review the "Arithmetic Expansion" section > > Umm ... I just did: > > http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag >_02_06_04 > > [...] > * The sizeof() operator and the prefix and postfix "++" and "--" operators > are not required. > [...]
so then you'd like to revise your statement that these are not bashisms, just common POSIX extensions that a lazy shell you're using hasnt implemented :P i'll see about tweaking the code to not use the extremely handy postfix operators -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
