On Fri, Sep 07, 2007 at 03:33:11AM -0400, Mike Frysinger wrote: > > --- ltp-full-20070831/testcases/network/generate.sh > > -#!/bin/sh > > +#!/bin/bash > > mmm, no ... i wrote that script to be POSIX compliant and everything used in > there is covered by POSIX last i checked, so without any real information, > this hunk is not acceptable
The thing that isn't is: 57: while [ $((cnt--)) -gt 0 ] ; do 70: while [ $((cnt--)) -gt 0 ] ; do Adam Barratt pointed out a great script called 'checkbashisms' which is distributed as part of Debian's devscripts package. I see some of the BSDs have also picked it up. http://svn.debian.org/wsvn/devscripts/trunk/scripts/checkbashisms.pl?op=file&rev=0&sc=0 It finds about 600 problems in the ltp tree, mostly echo -n and echo -e. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
