On Wednesday 05 September 2007, Matthew Wilcox wrote:
> Several of the LTP scripts use /bin/sh, but do not limit themselves to
> the features supported by POSIX sh.  For example, on my Ubuntu system,
> /bin/sh is a symlink to dash.  I propose the following patch to address
> this problem.  There's one bug I haven't been able to track down yet,
> but this is an improvement over the current state of affairs.

hmm, let's see ...

> --- ltp-full-20070831/IDcheck.sh
> -if [ $? == "0" ]; then
> +if [ $? = "0" ]; then

correct

> --- ltp-full-20070831/runltp
> -            [ -a "$SCENFILES" ] || \
> +            [ -e "$SCENFILES" ] || \
> -            [ -a "$SCENFILES" ] || \
> +            [ -e "$SCENFILES" ] || \

correct ... i always thought -a was a stupid extension, but oh well, that's 
historical baggage for ya

> --- ltp-full-20070831/testcases/network/generate.sh
> -#!/bin/sh
> +#!/bin/bash

mmm, no ... i wrote that script to be POSIX compliant and everything used in 
there is covered by POSIX last i checked, so without any real information, 
this hunk is not acceptable
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to