2013/1/15 Piotr Sipika:
> I would appreciate the community's feedback and would like to ask for
> the plugin to be included in mainline LXPanel source.
I like it and I would be happy to provide the Italian translation
you may want to check the following error messages from cppcheck (to
see them just run cppcheck src):
[src/httputil.c:107]: (error) Common realloc mistake: 'pInBuffer'
nulled but not freed upon failure
[src/httputil.c:137]: (error) Common realloc mistake: 'pInBuffer'
nulled but not freed upon failure
[src/location.c:166]: (error) Possible null pointer dereference:
pDestination - otherwise it is redundant to check if pDestination is
null at line 146
[src/lxpanel_plugin/weather.c:146]: (error) Memory leak: pLocation
[src/weatherwidget.c:1954]: (error) Possible null pointer dereference:
location_data - otherwise it is redundant to check if location_data is
null at line 1956
and the warnings from clang in the attached clang.txt file (the
configure step used gcc, but then I ran: make CC="clang --analyze")
when I run make clean I get this error:
dh_clean: cannot read debian/control: No such file or directory
--
Daniele Forsi
Making all in src
yahooutil.c:444:22: warning: Value stored to 'pcImageURL' during its
initialization is never read
char * pcImageURL = strtok_r(pcContent, "\"", &pcSavePtr);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
yahooutil.c:548:39: warning: Access to field 'children' results in a
dereference of a null pointer (loaded from variable 'pCurr')
xmlNodePtr pChild = pCurr->xmlChildrenNode;
^~~~~
yahooutil.c:827:47: warning: Dereference of null pointer (loaded from variable
'pList')
*pList = g_list_prepend(*pList, pEntry);
^~~~~~
yahooutil.c:853:23: warning: Dereference of null pointer (loaded from variable
'pForecast')
*pForecast = processChannelNode(pNode, pEntry);
^~~~~~~~~~
yahooutil.c:939:8: warning: Value stored to 'iRet' during its initialization is
never read
gint iRet = getWOEIDQuery(cQueryBuffer, pcEscapedLocation);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
yahooutil.c:999:8: warning: Value stored to 'iRet' during its initialization is
never read
gint iRet = getForecastQuery(cQueryBuffer, pczWOEID, czUnits);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
6 warnings generated.
location.c:166:3: warning: Dereference of null pointer (loaded from variable
'pDestination')
*pDestination = g_try_new0(LocationInfo, 1);
^~~~~~~~~~~~~
1 warning generated.
weatherwidget.c:1529:46: warning: Access to field 'pcAlias_' results in a
dereference of a null pointer (loaded from variable 'location')
location->pcAlias_);
^~~~~~~~
1 warning generated.
Making all in src/lxpanel_plugin
../../src/yahooutil.c:444:22: warning: Value stored to 'pcImageURL' during its
initialization is never read
char * pcImageURL = strtok_r(pcContent, "\"", &pcSavePtr);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/yahooutil.c:548:39: warning: Access to field 'children' results in a
dereference of a null pointer (loaded from variable 'pCurr')
xmlNodePtr pChild = pCurr->xmlChildrenNode;
^~~~~
../../src/yahooutil.c:853:23: warning: Dereference of null pointer (loaded from
variable 'pForecast')
*pForecast = processChannelNode(pNode, pEntry);
^~~~~~~~~~
../../src/yahooutil.c:827:47: warning: Dereference of null pointer (loaded from
variable 'pList')
*pList = g_list_prepend(*pList, pEntry);
^~~~~~
../../src/yahooutil.c:939:8: warning: Value stored to 'iRet' during its
initialization is never read
gint iRet = getWOEIDQuery(cQueryBuffer, pcEscapedLocation);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/yahooutil.c:999:8: warning: Value stored to 'iRet' during its
initialization is never read
gint iRet = getForecastQuery(cQueryBuffer, pczWOEID, czUnits);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
6 warnings generated.
../../src/location.c:166:3: warning: Dereference of null pointer (loaded from
variable 'pDestination')
*pDestination = g_try_new0(LocationInfo, 1);
^~~~~~~~~~~~~
1 warning generated.
../../src/weatherwidget.c:1529:46: warning: Access to field 'pcAlias_' results
in a dereference of a null pointer (loaded from variable 'location')
location->pcAlias_);
^~~~~~~~
1 warning generated.
------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612
_______________________________________________
Lxde-list mailing list
Lxde-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxde-list
