Hello!
Piotr Sipika has written on Sunday, 6 July, at 19:05:
>I'll put in some time here and there, and will provide status, hopefully
>on a weekly basis.
No updates from you, though I found some updates in your repository.
Few notes on it:
1) the function gtk_weather_button_pressed() will be never called for
button 3 since the panel will catch and handle it, therefore the item
'Refresh' should be added in callback .update_context_menu() instead of
creating unused popup menu.
2) gtk_weather_preferences_dialog_response() should never destroy the
preferences dialog because panel handles that thing.
3) gtk_weather_create_preferences_dialog() should always create new
preferences dialog due to (2) and never use the same one again.
4) might it be better to use conditional compilation instead of using
conditional execution? That way we can omit some unused code when it's
used as panel plugin.
With best regards,
Andriy.
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Lxde-list mailing list
Lxde-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxde-list
