On 08/01/2014 08:33 PM, Andrej N. Gritsenko wrote: > Hello! Hi! > No updates from you, though I found some updates in your repository. Yup, I try to work on the plugin when I have some time, but I don't want to spam the list with updates for incomplete functionality...
> Few notes on it: > > 1) the function gtk_weather_button_pressed() will be never called for > button 3 since the panel will catch and handle it, therefore the item > 'Refresh' should be added in callback .update_context_menu() instead of > creating unused popup menu. > 2) gtk_weather_preferences_dialog_response() should never destroy the > preferences dialog because panel handles that thing. > 3) gtk_weather_create_preferences_dialog() should always create new > preferences dialog due to (2) and never use the same one again. > 4) might it be better to use conditional compilation instead of using > conditional execution? That way we can omit some unused code when it's > used as panel plugin. Thanks for these suggestions. I'll put those in as soon as I can. > With best regards, > Andriy. Cheers! Piotr ------------------------------------------------------------------------------ Infragistics Professional Build stunning WinForms apps today! Reboot your WinForms applications with our WinForms controls. Build a bridge from your legacy apps to the future. http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
