On Sat, Nov 26, 2016 at 6:52 PM, Andrej N. Gritsenko <and...@rep.kiev.ua> wrote: > Hello! > > You have written on Saturday, 26 November, at 16:56: >>Recently there were some improvements in pcmanfm-qt and libfm-qt, >>including the new button-style path bar and simple emblem support. So >>I'd suggest making a new release for these components. >>Any objections or issues? > > I have an objection on including new features and string changes into > libfm 1.2.x release, new features (especially those that produce new > issues, as it is with emblems feature) should come into next release,
The emblem change is backward compatible and there are no UI string or ABI changes. It's safe to include that in the current release. If you have concerns, it's still safe to just cherry-pick that commit. > i.e. 1.3. And I want to release 1.2.5 very soon, where I want to fix few > more bugs in addition to already fixed ones. Could you include emblems > changes into libfm-qt instead, until 1.3 will be released, if you want it > to be in some release, please? I wish 1.3 to happen next year anyway, so > this will be just temporarily. Thank you for understanding. Putting this in libfm-qt can be more difficult since the best place the fetch the info is within the file info job of libfm core. Besides, this feature is not toolkit-specific so it's better to let the gtk+ version have it as well. Regards > With best regards, > Andriy. ------------------------------------------------------------------------------ _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
