Hello! You have written on Saturday, 26 November, at 21:02: >On Sat, Nov 26, 2016 at 6:52 PM, Andrej N. Gritsenko <and...@rep.kiev.ua> >wrote:
>> I have an objection on including new features and string changes into >> libfm 1.2.x release, new features (especially those that produce new >> issues, as it is with emblems feature) should come into next release, >The emblem change is backward compatible and there are no UI string or >ABI changes. >It's safe to include that in the current release. >If you have concerns, it's still safe to just cherry-pick that commit. Yes, I have concerns, as that change: 1) changes libfm behavior on local files (it will now query GVFS for extra data, that was never done before); 2) produces an issue https://github.com/lxde/pcmanfm-qt/issues/397 which I would classify as a blocker and https://github.com/lxde/libfm/pull/19 is not even a workaround but a dirty hack, as it isn't thread-safe while rest of that class APIs are (and should be). So in short, that change isn't suitable for 1.2.5, I'm sorry. In 1.3.0 I plan to add fm_enable_features() call so this and similar time-consuming features can be individually enabled, so it's where this change really belongs. And also I had a little bit different approach for this feature, not an enforsed (not every widget would want emblemed icon, e.g. menu). With best regards, Andriy. ------------------------------------------------------------------------------ _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
