Re: test of math previews

[Guillaume M-M]

Le 04/06/2015 20:17, Scott Kostyshak a écrit :

On Thu, Jun 4, 2015 at 3:05 PM, Enrico Forestieri <for...@lyx.org> wrote:

On Thu, Jun 04, 2015 at 02:44:56PM -0400, Scott Kostyshak wrote:

On Thu, Jun 4, 2015 at 2:34 PM, Scott Kostyshak <skost...@lyx.org> wrote:

On Thu, Jun 4, 2015 at 2:31 PM, Enrico Forestieri <for...@lyx.org> wrote:

On Thu, Jun 04, 2015 at 06:33:28PM +0100, Guillaume M-M wrote:

2) an assertion violation that happen on copy-paste with preview (does not
happen without preview). This is a regression in master, does not happen in
the stable branch.

I can reproduce the assertion. Bisect points at 73460423 and it was
backported to stable at 6ac04e21 where it asserts in the same way.

Ah thank you for catching this and bisecting. I will revert in branch
and master.

Can someone please confirm that I should indeed revert?
I took a look at lyx-preview-explosion.lyx and I can indeed reproduce
the assertion. My guess though is that the referenced commits expose a
different bug that has to do with previews and macros. But in the end
from a user perspective it is a regression. Thus, I think I should
revert.

Wouldn't it be better trying to understand why it asserts such that it
can be avoided?

Yes much better. However, we are close to release so I was thinking to
revert in the meantime. And second, I don't understand the underlying
code involving macros at all so it would be up to someone else to do
that. From what I remember of previous issues regarding preview +
macro, this is a complicated issue over my head.

Scott

diff --git a/src/Text3.cpp b/src/Text3.cpp
index 3359e35..0d256c2 100644
--- a/src/Text3.cpp
+++ b/src/Text3.cpp
@@ -1269,7 +1269,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                bv->buffer().errors("Paste");
                cur.clearSelection(); // bug 393
                cur.finishUndo();
-               bv->buffer().updatePreviews();
+//             bv->buffer().updatePreviews();
                break;
        }

The attached file produces a similar lassert when preview is on. No copy-paste involved, just open the file. (Sorry for not refining the example more, I think it's already small enough.) Can leave lyx in a crash-on-startup state, forcing to remove by hand the line \preview from preferences. Affects master at cda4589f, and stable at 7013445b plus the following patch that removes the line added by 6ac04e21:

lyx-bug-lassert-preview-startup.lyx
Description: application/lyx