On Sun, Nov 01, 2015 at 01:13:39PM +0100, Kornel Benko wrote: > Am Sonntag, 1. November 2015 um 11:55:47, schrieb Kornel Benko > <kor...@lyx.org> > > Am Sonntag, 1. November 2015 um 11:52:26, schrieb Kornel Benko > > <kor...@lyx.org> > > > Am Samstag, 31. Oktober 2015 um 19:11:10, schrieb Scott Kostyshak > > > <skost...@lyx.org> > > > > On Sat, Oct 31, 2015 at 05:57:46PM -0400, Scott Kostyshak wrote: > > > > > On Sat, Oct 31, 2015 at 09:21:15PM +0000, Guenter Milde wrote: > > > > > > > > > > I'd prefer you to do this. > > > > > > > > > > OK I'll work on it. > > > > > > > > Does the attached patch look good? > > > > > > > > We need to do something similar for the other FIXMEs you put in > > > > 1523fc60, right? > > > > > > > > Scott > > > > > > Applying this patch now _all_ export tests 'export/.*(pdf|dvi)' are > > > failing. > > > Probably because the patch is only partial I suppose. > > > > > > > I was too fast. The first 208 (out of 3761) did not pass as I wrote the > > mail. > > Now I see some other passing. > > I will report the outcome, have to wait a 'little' more. > >
Thanks for running the tests, Kornel. > It turned out, that all but the first 208 testcases pass. > Comparing the failed with the list of previously failed, there is no > difference. I think that ctest always runs the failed tests first. This has surprised me before. > So even if your patch does not improve any test, it does not harm either. OK let's wait and see what Günter says then. I'm not even confident my patch is correct. If he confirms that it is, then I can go on and make the full patch. I'm not sure if the full patch is supposed to fix any tests (although it would be nice if it whittles down some of those 208). Scott
