On Mon, Nov 02, 2015 at 10:40:27PM +0000, Guenter Milde wrote: > On 2015-11-01, Guenter Milde wrote: > > Dear Scott, > > > thanks for the patch. > > I modified it to use UTF8 with XeTeX without the > \inputencoding commands. A short test here showed that this > helps with Umlauts or Cyrillic charactes in the PDF Info. > > Give it a try.
Nice. I am not able to test it because I don't understand the underlying issue, but I did look at the code and it looks good to me. I have a couple picky comments about using tabs instead of spaces below (by the way, there are ways of configuring Git to catch these types of formatting inconsistencies, as well as your editor. Ask on the list if curious). > + if (inputenc_loaded) replace spaces with tab? > + if (inputenc_loaded) replace spaces with tabs? I would say go ahead and commit if you are satisfied with it. From what I understand, the patch is now a complete patch in the sense that it is a full step forward. I know there are other things you want to do, but I think this patch is a self-contained step forward and not a partial patch. If that's correct, then I suggest you commit. Let me know if you want me to run the export tests before/after. Scott
