On 11/23/2015 10:33 PM, Scott Kostyshak wrote:
> On Mon, Nov 23, 2015 at 09:10:23PM -0500, Richard Heck wrote:
>
>> Uwe, please test that this new patch does what you want it to do. I've
>> tested it, but only minimally.
>>
>> Another issue is that \verbatim* is not presently handled properly by
>> tex2lyx. If we are going to add verbatim* support for 2.2, then it seems
>> to me that we should also have tex2lyx support. What's worse is that
>> tex2lyx makes a total mess of that other file I've attached.
> From what I understand of the steps in Development.lyx, this is not
> required. Should we change the rules? Currently it states:
>
> 7. If you did not implement full tex2lyx support of the new
> feature, add a line to src/tex2lyx/TODO.txt describing the missing
> bits. Note that it is perfectly fine if you do not add full
> tex2lyx support for a new feature: The updating recommendation
> above is only issued for the syntax of the produced .lyx file. It
> is no problem if some features supported by LyX are still output
> as ERT by tex2lyx, since the problems in the past that resulted in
> the update recommendation were related to mixed version syntax,
> not ERT.
>
> So why can't Uwe just add a line to src/tex2lyx/TODO.txt as
> detailed above?
I was mostly thinking that (a) if we're going to add this for 2.2, the
tex2lyx part should also be done---the rule you quoted applies to
mid-cycle commits and doesn't say anything about what should be done for
a major release---and (b) that the test file I attached (a minimal
modification of the existing one) gets totally mangled. The \verbatim*
command isn't even output properly as ERT.
This actually seems to be an existing bug:
Creating file /music/cvs/lyx/lyx-devel/src/tex2lyx/test/verbatim.lyx
Line ~3: parse error: found 'end' unexpectedly
Tokens: \documentclass [{,1]article[},2][1\n,5]
\begin [{,1]document[},2][1\n,5]
\begin [{,1]verbatim[},2][ ,12][\,12]verbatim[ ,12][$,12]src[ ,12]set[
,12]packetSize[_,12][ ,12][1,12][0,12][0,12][0,12][0,12][0,12][
,12][\,12]end[{,12]verbatim[},12][1\n,5]
\begin [{,1]verbatim[*,12][},2] \verbatim [*,12] [$,3]src set
packetSize[_,8] [1,12][0,12][0,12][0,12][0,12][0,12] \end pos: 133
Line ~4: parse error: found 'end' unexpectedly
Tokens: \documentclass [{,1]article[},2][1\n,5]
\begin [{,1]document[},2][1\n,5]
\begin [{,1]verbatim[},2][ ,12][\,12]verbatim[ ,12][$,12]src[ ,12]set[
,12]packetSize[_,12][ ,12][1,12][0,12][0,12][0,12][0,12][0,12][
,12][\,12]end[{,12]verbatim[},12][1\n,5]
\begin [{,1]verbatim[*,12][},2] \verbatim [*,12] [$,3]src set
packetSize[_,8] [1,12][0,12][0,12][0,12][0,12][0,12] \end
[{,1]verbatim[*,12][},2][1\n,5]
\end pos: 146
Richard
