Le 22/09/2016 à 04:06, Enrico Forestieri a écrit :
Would something like that work for us? That looks good.

Yep, that seems producing an image with same quality. The patch would be
the attached one. Please, apply if you like it.

Thaks for the patch, I pushed it. I was tempted to do the same for the banner, but decided to wait a bit.

Actually, most of the used of getPixmap are like
  QIcon(getPixmap(...)).pixmap(somesize);

It looks like a strange code path to me. What does getPixmap return in the case of a svg? Some rasterized version of the svg? Then how does it help to go through a QIcon and then back to QPixmap?

It would look better to me to have a getIcon function which returns a QIcon, so that we can directly render the svg at the right size. Or did I misunderstand how this works?

JMarc

Reply via email to