On Tue, Sep 14, 2010 at 16:43, Óscar Fuentes <[email protected]> wrote: > I've played for some minutes with the feature. I see that Phil > reimplemented it all. IMHO the implementation is over-engineered, but > that's not a problem with me. Some comments follow, from a user POV: > > Text is wider than the buffer (see logging on a 80 character wide > frame). The old implementation adapted the display to the number > of columns of the window.
Hadn't noticed that, but I see it now that I reduce the size of my terminal. Maybe Emacs has some framework for dealing with this sort of thing? > There are lots of missing options for logging. Why? Well, there's a lot of git-log(1) options, presumably they're missing since nobody's added them yet. > Pressing `-a' instead of just `a' is awkward. And those keys require a > Shift press on some keyboards. Do we really need the `-' and `=' > prefixes? As a remedy for avoiding keybinding collisions, they seem > pretty weak. Hadn't noticed that since - is right next to my pinky (dvorak), but maybe this should be customizable. > After entering the *magit-key* menu, it is not obvious what to do. Click > on the items? Move the cursor on top of an item and press ENTER? > > If the user presses some key that *magit-key* does not recognizes, > "Buffer is read-only: #<buffer *magit-key*>" is displayed on the > minibuffer. This is not very friendly. Something like "key not > recognized, press some combination shown in green" would be more > appropiate. > > Where is the help feature? It is a very bad thing that the user can't > see how to get help as soon as it enters *magit-key*. Actually, he is > not informed about the exitence of that feature at all. (or was it > removed?) Aside from functions needing docstrings what sort of help system do you have in mind?
