At Wed, 15 Sep 2010 00:58:26 +0200,
Óscar Fuentes wrote:
>
> Ævar Arnfjörð Bjarmason <[email protected]>
> writes:
>
> >> Text is wider than the buffer (see logging on a 80 character wide
> >> frame). The old implementation adapted the display to the number
> >> of columns of the window.
> >
> > Hadn't noticed that, but I see it now that I reduce the size of my
> > terminal. Maybe Emacs has some framework for dealing with this sort of
> > thing?
>
> Just query the number of columns of the window and then adapt the
> position of the items to it. It is not so complex.
>
> >> There are lots of missing options for logging. Why?
> >
> > Well, there's a lot of git-log(1) options, presumably they're missing
> > since nobody's added them yet.
>
> My implementation has 17 options for `log'. Each option requires just
> one trivial line of code. I think that Phil's implementation doesn't
> require much more for reflecting git options.
Do you have another branch? I count 11 which aren't too dissimilar to
the ones I added. Here's your definition:
(list '("Log" ?l "One line log" magit-log)
'("Log" ?L "Detailed log" magit-log-long)
'("Log" ?h "Reflog" magit-reflog)
'("Log" ?H "Reflog head" magit-reflog-head)
'("Log" ?a "--all" "All branches" magit-true)
'("Log" ?g "--grep=" "Containing regexp" read-from-minibuffer)
'("Log" ?A "--author=" "By author" read-from-minibuffer)
'("Log" ?C "--committer=" "By committer" read-from-minibuffer)
'("Log" ?F "--first-parent"
"Follow only first parent" magit-true)
'("Log" ?B "--branches=" "Branches" read-from-minibuffer)
'("Log" ?R "--relative=" "Restrict to path" read-directory-name)
Phil.
