On Wed, Sep 15, 2010 at 23:10, Óscar Fuentes <[email protected]> wrote: > Ævar Arnfjörð Bjarmason <[email protected]> > writes: > > [snip] > >> E.g. commiting in the old system was much quicker. Commiting with a >> signoff was just "C-c C-s C-c" in the commit window, but now it's "c" >> -> wait for another window "-s" "c". > > Is the wait noticeable? On my netbook, with my implementation, the > window appears almost immediately (may 1 tenth of second.) And the > keypresses after the initial key that triggers the window are buffered, > so they are applied as soon as the window appears if you type them > really fast.
Not really, but they're two dialogs so one has a tendency to wait for the second one. You can also do C-c C-s C-c with your hand posed over the same keys, but with "-s" added to the mix you have to move it, so you can't do it in one quick movement. > On my implementation (sorry for referencing it so often, but I just > played with Phil's a few minutes) you can add your own > commands. Anyways, it would be c (for commit group) s (for signoff) and > c (for commit). "csc" seems pretty quick. Yeah, sounds better than the original even. >> Similarly I almost never want to push to a non-default repo, but "P" >> now brings up a secondary dialog. I'd prefer if I had to bring that >> one up with C-u P by default. > > My solution for this was to put the most used command on the same key > that pops the menu. This would be "PP". I guess that Phil's > implementation already does that. Maybe I just have to get used to picking the default like that. >> A lot of this could just be solved by making things configurable, >> e.g. I'd like to not have the commit dialog and instead just have a >> simple hook so I can automatically add sign-off for certain projects, >> and skip it elsewhere. > > Or you just can customize the keys. Changing the key that triggers the > menu for every group is the same as changing any other keybinding on > Emacs. At least on my implementaton, a command executed from the magit > menu is a normal magit defun, that you can execute with M-x or bind a > key to it. > > Finally, please keep in mind that we must renounce to a bit of the > convenience we are accustomed to if we want to extend the capabilities > of magit. Right, I'm all for that. Just pointing out some minor workflow issues that I've had.
