Hello Phil. Philip Jackson <[email protected]> writes:
>> Pressing `-a' instead of just `a' is awkward. And those keys require >> a Shift press on some keyboards. Do we really need the `-' and `=' >> prefixes? As a remedy for avoiding keybinding collisions, they seem >> pretty weak. > > I'd like more feedback. Now that I've looked at your more recent > branch it seems you're simply running into the problem which, in part, > prompted this work in the first place. You're using bindings just > because they're free. The motivation for key-groups was that the feature set of git is too large to map into single keystrokes. Key-groups partitions the feature set and makes possible to map features either to direct keys (for the most used variants) or to combinations (for option+option+...+command). So the combinatorial problem is solved. As far as the number of commands and options for a key-group is less than 70 or so, the problem of unavailable keys is solved. The problem of not having intuitive keybindings for every command and option is unavoidable. Last, but not least: one of the things I appreciate most of magit is the feeling of swiftness one gets when presses one or two keys and something happens almost immediately, thanks to git's efficiency. As we require more keypresses, that sensation diminishes. So IMHO we should consider the necessity of those `-' and `=' prefixes.
