OK, I remade the patch to omit the new IntCharMap stuff that isn't ready yet. The new unit test for the OpenIntIntHashMap is pretty nearly comprehensive at the API level, and also provides test coverage for the abstract classes in its inheritance graph and the IntArrayList and some of its inheritance graph.
Making distinct unit tests for abstract classes is of course a painful process of creating a dummy class to test, so I hope that you are content to get coverage via tests of the concrete classes that inherit from the abstract classes. On Mon, Dec 14, 2009 at 10:06 AM, Benson Margulies <[email protected]> wrote: > I didn't ask anyone to commit anything. > > I suggested a reorg. They volunteered to do the reorg ASAP. I asked > them to hold off the reorg until 222 was ready to commit and > committed. They agreed. > > On Mon, Dec 14, 2009 at 9:56 AM, Sean Owen <[email protected]> wrote: >> Sorry, what were you asking to commit then? >> >> On Mon, Dec 14, 2009 at 2:54 PM, Benson Margulies <[email protected]> >> wrote: >>> Please, don't do that. 222 is not ready to commit. Please give me a >>> little more time on it. I'll have it plausibly ready to commit by >>> tomorrow, then you can commit, and reorg, and I'll pick up from there. >> >
