[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121060#comment-13121060
 ] 

Jonathan Eagles commented on MAPREDUCE-2913:
--------------------------------------------

Running TestMRJobs.testFailingMapper with code changed as describe in 
description without the .FAILED

$ mvn -Dtest=TestMRJobs#testFailingMapper test

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.mapreduce.v2.TestMRJobs
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 32.51 sec <<< 
FAILURE!

Results :

Failed tests:   testFailingMapper(org.apache.hadoop.mapreduce.v2.TestMRJobs): 
expected:<FAILED> but was:<TIPFAILED>

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

                
> TestMRJobs.testFailingMapper does not assert the correct thing.
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-2913
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2913
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Jonathan Eagles
>            Priority: Critical
>             Fix For: 0.23.0, 0.24.0
>
>
> {code}
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         events[0].getStatus().FAILED);
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         events[1].getStatus().FAILED);
> {code}
> when optimized would be
> {code}
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         TaskCompletionEvent.Status.FAILED);
>     Assert.assertEquals(TaskCompletionEvent.Status.FAILED, 
>         TaskCompletionEvent.Status.FAILED);
> {code}
> obviously these assertions will never fail.  If we remove the 
> {code}.FAILED{code} the asserts no longer pass. This could be because MRApp 
> mocks out the task launcher and never actually launches anything.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to