[
https://issues.apache.org/jira/browse/MAPREDUCE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121101#comment-13121101
]
Robert Joseph Evans commented on MAPREDUCE-2913:
------------------------------------------------
OK after thinking about the fix, there should really be no issue with them
being switched unless speculative execution is enabled and something very odd
happens. So Jon you can probably ignore my previous comment.
> TestMRJobs.testFailingMapper does not assert the correct thing.
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-2913
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2913
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, test
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Jonathan Eagles
> Priority: Critical
> Fix For: 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2913.patch
>
>
> {code}
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> events[0].getStatus().FAILED);
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> events[1].getStatus().FAILED);
> {code}
> when optimized would be
> {code}
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> TaskCompletionEvent.Status.FAILED);
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> TaskCompletionEvent.Status.FAILED);
> {code}
> obviously these assertions will never fail. If we remove the
> {code}.FAILED{code} the asserts no longer pass. This could be because MRApp
> mocks out the task launcher and never actually launches anything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
