[
https://issues.apache.org/jira/browse/MAPREDUCE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121112#comment-13121112
]
Jonathan Eagles commented on MAPREDUCE-2913:
--------------------------------------------
bq. Have you run this multiple times? is there any possibility of a race
condition between the different tasks so that they switch status?
Great question to ask. The getTaskCompletionEvents API return the events in
chronological order. Both task events fail in this test. The code ensures that
the last failing task will cause the TaskInProgress to fail which will upgrad
the last event status to TIPFAILED as return by getTaskCompletionEvents.
I have run this test 10 times consecutively to verify my understanding of the
code lines up with the expected results.
> TestMRJobs.testFailingMapper does not assert the correct thing.
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-2913
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2913
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, test
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Jonathan Eagles
> Priority: Critical
> Fix For: 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2913.patch
>
>
> {code}
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> events[0].getStatus().FAILED);
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> events[1].getStatus().FAILED);
> {code}
> when optimized would be
> {code}
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> TaskCompletionEvent.Status.FAILED);
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> TaskCompletionEvent.Status.FAILED);
> {code}
> obviously these assertions will never fail. If we remove the
> {code}.FAILED{code} the asserts no longer pass. This could be because MRApp
> mocks out the task launcher and never actually launches anything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
