[
https://issues.apache.org/jira/browse/MAPREDUCE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121100#comment-13121100
]
[email protected] commented on MAPREDUCE-2913:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2214/#review2349
-----------------------------------------------------------
Ship it!
Looks fine.
- Mark
On 2011-10-05 16:10:53, Jonathan Eagles wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2214/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-05 16:10:53)
bq.
bq.
bq. Review request for Tom Graves, Robert Evans, Ravi Prakash, Mark
Holderbaugh, and Anupam Seth.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In this test, the max task attempts is set to 2. As each map task attempt
fails, this sets the first task attempt to FAILED, but sets the second map task
attempt to TIPFAILED since it also fails the TaskInProgress since it is the
last map task attempt.
bq.
bq.
bq. This addresses bug MAPREDUCE-2913.
bq. http://issues.apache.org/jira/browse/MAPREDUCE-2913
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java
aa832aa
bq.
bq. Diff: https://reviews.apache.org/r/2214/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran test for test with incorrect assertion
bq.
bq. mvn -Dtest=TestMRJobs#testFailingMapper test
bq.
bq. and verify success
bq.
bq.
bq. Thanks,
bq.
bq. Jonathan
bq.
bq.
> TestMRJobs.testFailingMapper does not assert the correct thing.
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-2913
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2913
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, test
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Robert Joseph Evans
> Assignee: Jonathan Eagles
> Priority: Critical
> Fix For: 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2913.patch
>
>
> {code}
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> events[0].getStatus().FAILED);
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> events[1].getStatus().FAILED);
> {code}
> when optimized would be
> {code}
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> TaskCompletionEvent.Status.FAILED);
> Assert.assertEquals(TaskCompletionEvent.Status.FAILED,
> TaskCompletionEvent.Status.FAILED);
> {code}
> obviously these assertions will never fail. If we remove the
> {code}.FAILED{code} the asserts no longer pass. This could be because MRApp
> mocks out the task launcher and never actually launches anything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
