[
https://issues.apache.org/jira/browse/MAPREDUCE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784650#comment-16784650
]
Adam Antal commented on MAPREDUCE-7188:
---------------------------------------
Thanks for the patch [~shwetayakkali]. It's nice to see this file becoming
prettier.
Some minor comments:
* {{getElement()}} and {{getDuration()}} do have their closing braces in one
line with the return statement. Can you move them to a separate line to be in
line with the codestyle?
* In {{combine()}}, in the ternary operator before the colon there's still
missing a space.
Jenkins says that there's still 3 checkstyle issue with this file, but I could
only find this one: the following line is too long (81 character)
{noformat}
final long duration = Util.parseLongVariable("duration", s.substring(i, j));
{noformat}
Could you handle these points?
> [Clean-up] Remove NULL check before instanceof and fix checkstyle issue in
> TaskResult
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7188
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Shweta
> Priority: Minor
> Attachments: MAPREDUCE-7188.001.patch, MAPREDUCE-7188.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
