[
https://issues.apache.org/jira/browse/MAPREDUCE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785148#comment-16785148
]
Shweta commented on MAPREDUCE-7188:
-----------------------------------
Thanks for the review [~templedf]. Sure, I have uploaded a new patch to take
care of not splitting the line on a dot.
Yes, {{TaskResult()}} doesn't seem to have any usages. Sure, it might be used
in some cases for reflection. Is there a way to find this from code?
If default constructor {{TaskResult()}} doesn't have usages (not used via
Reflection too), will keeping it {{private}} help in the sense that we don't
want any classes to instantiate the object w/o parameters?
> [Clean-up] Remove NULL check before instanceof and fix checkstyle issue in
> TaskResult
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7188
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Shweta
> Assignee: Shweta
> Priority: Minor
> Attachments: MAPREDUCE-7188.001.patch, MAPREDUCE-7188.002.patch,
> MAPREDUCE-7188.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
