[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7320?focusedWorklogId=557582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557582
 ]

ASF GitHub Bot logged work on MAPREDUCE-7320:
---------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Feb/21 23:11
            Start Date: 24/Feb/21 23:11
    Worklog Time Spent: 10m 
      Work Description: amahussein commented on a change in pull request #2722:
URL: https://github.com/apache/hadoop/pull/2722#discussion_r582372117



##########
File path: 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/ClusterMapReduceTestCase.java
##########
@@ -43,8 +45,21 @@
  * The DFS filesystem is formated before the testcase starts and after it ends.
  */
 public abstract class ClusterMapReduceTestCase {
+  private static final String TEST_ROOT_DEFAULT_PATH =
+      System.getProperty("test.build.data", "target/test-dir");

Review comment:
       The point that if the property "test.build.data" is set globally to the 
unit tests, then the `ClusterMapReduceTestCase.java` should also reads this 
value. Otherwise, all unit tests would not consume the global properties set to 
the JVM. It will be a mess in the folders




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 557582)
    Time Spent: 1.5h  (was: 1h 20m)

> ClusterMapReduceTestCase does not clean directories
> ---------------------------------------------------
>
>                 Key: MAPREDUCE-7320
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7320
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Running Junits that extend {{ClusterMapReduceTestCase}} generate lots of 
> directories and folders without cleaning them up.
> For example:
> {code:bash}
> men test -Dtest=TestMRJobClient{code}
> generates the following directories:
> {code:bash}
> - target
>    -+ ConfigurableMiniMRCluster_315090884
>    -+ ConfigurableMiniMRCluster_1335188990
>    -+ ConfigurableMiniMRCluster_1973037511
>    -+ test-dir
>         -+ dfs
>         -+ hadopp-XYZ-01
>         -+ hadopp-XYZ-02 
>         -+ hadopp-XYZ-03
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to