[
https://issues.apache.org/jira/browse/MAPREDUCE-7320?focusedWorklogId=557588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557588
]
ASF GitHub Bot logged work on MAPREDUCE-7320:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/21 23:17
Start Date: 24/Feb/21 23:17
Worklog Time Spent: 10m
Work Description: amahussein commented on a change in pull request #2722:
URL: https://github.com/apache/hadoop/pull/2722#discussion_r582374895
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
##########
@@ -229,6 +229,31 @@ public static int uniqueSequenceId() {
return sequence.incrementAndGet();
}
+ /**
+ * Creates a directory for the data/logs of the unit test.
+ * It first delete the directory if it exists.
+ *
+ * @param testClass the unit test class.
+ * @param defaultTargetRootDir the directory where the class directory is
+ * created.
+ * @return the Path of the root directory.
+ */
+ public static Path setupTestRootDir(Class<?> testClass,
+ String defaultTargetRootDir) {
+ // setup the test root directory
+ String targetTestDir =
+ System.getProperty(SYSPROP_TEST_DATA_DIR, defaultTargetRootDir);
+ Path testRootDirPath =
+ new Path(targetTestDir, testClass.getSimpleName());
+ System.setProperty(GenericTestUtils.SYSPROP_TEST_DATA_DIR,
+ testRootDirPath.toString());
Review comment:
Also, if I do not set this property, the diff will be very large to get
around it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 557588)
Time Spent: 2h (was: 1h 50m)
> ClusterMapReduceTestCase does not clean directories
> ---------------------------------------------------
>
> Key: MAPREDUCE-7320
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7320
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Running Junits that extend {{ClusterMapReduceTestCase}} generate lots of
> directories and folders without cleaning them up.
> For example:
> {code:bash}
> men test -Dtest=TestMRJobClient{code}
> generates the following directories:
> {code:bash}
> - target
> -+ ConfigurableMiniMRCluster_315090884
> -+ ConfigurableMiniMRCluster_1335188990
> -+ ConfigurableMiniMRCluster_1973037511
> -+ test-dir
> -+ dfs
> -+ hadopp-XYZ-01
> -+ hadopp-XYZ-02
> -+ hadopp-XYZ-03
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
