[
https://issues.apache.org/jira/browse/MAPREDUCE-7320?focusedWorklogId=557585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557585
]
ASF GitHub Bot logged work on MAPREDUCE-7320:
---------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/21 23:14
Start Date: 24/Feb/21 23:14
Worklog Time Spent: 10m
Work Description: amahussein commented on a change in pull request #2722:
URL: https://github.com/apache/hadoop/pull/2722#discussion_r582373743
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/ClusterMapReduceTestCase.java
##########
@@ -43,8 +45,21 @@
* The DFS filesystem is formated before the testcase starts and after it ends.
*/
public abstract class ClusterMapReduceTestCase {
+ private static final String TEST_ROOT_DEFAULT_PATH =
+ System.getProperty("test.build.data", "target/test-dir");
+ private static Path testRootDir;
+
private MiniDFSCluster dfsCluster = null;
- private MiniMRCluster mrCluster = null;
+ private MiniMRClientCluster mrCluster = null;
+
+ protected static void setupClassBase(Class<?> testClass) throws Exception {
+ // setup the test root directory
+ testRootDir = GenericTestUtils.setupTestRootDir(testClass,
+ TEST_ROOT_DEFAULT_PATH);
+ System.setProperty(GenericTestUtils.SYSPROP_TEST_DATA_DIR,
Review comment:
It will be set for the JVM executing the unittest. Each unit test should
then have its own property. Then they should not overlap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 557585)
Time Spent: 1h 50m (was: 1h 40m)
> ClusterMapReduceTestCase does not clean directories
> ---------------------------------------------------
>
> Key: MAPREDUCE-7320
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7320
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Running Junits that extend {{ClusterMapReduceTestCase}} generate lots of
> directories and folders without cleaning them up.
> For example:
> {code:bash}
> men test -Dtest=TestMRJobClient{code}
> generates the following directories:
> {code:bash}
> - target
> -+ ConfigurableMiniMRCluster_315090884
> -+ ConfigurableMiniMRCluster_1335188990
> -+ ConfigurableMiniMRCluster_1973037511
> -+ test-dir
> -+ dfs
> -+ hadopp-XYZ-01
> -+ hadopp-XYZ-02
> -+ hadopp-XYZ-03
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
