[ 
https://issues.apache.org/jira/browse/MAPREDUCE-7320?focusedWorklogId=558021&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558021
 ]

ASF GitHub Bot logged work on MAPREDUCE-7320:
---------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Feb/21 16:47
            Start Date: 25/Feb/21 16:47
    Worklog Time Spent: 10m 
      Work Description: amahussein commented on a change in pull request #2722:
URL: https://github.com/apache/hadoop/pull/2722#discussion_r582993637



##########
File path: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
##########
@@ -171,8 +173,11 @@ public MiniYARNCluster(
     this.numLocalDirs = numLocalDirs;
     this.numLogDirs = numLogDirs;
     this.enableAHS = enableAHS;
-    String testSubDir = testName.replace("$", "");
-    File targetWorkDir = new File("target", testSubDir);
+    String testSubDir = testName.replace("$", "").concat("-yarn");

Review comment:
       I think even better it should be unique folder name "yarn_TESTXYZ" . 
This way, multiple test cases within the same class won't override the existing 
folder.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 558021)
    Time Spent: 2h 40m  (was: 2.5h)

> ClusterMapReduceTestCase does not clean directories
> ---------------------------------------------------
>
>                 Key: MAPREDUCE-7320
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7320
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Ahmed Hussein
>            Assignee: Ahmed Hussein
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Running Junits that extend {{ClusterMapReduceTestCase}} generate lots of 
> directories and folders without cleaning them up.
> For example:
> {code:bash}
> men test -Dtest=TestMRJobClient{code}
> generates the following directories:
> {code:bash}
> - target
>    -+ ConfigurableMiniMRCluster_315090884
>    -+ ConfigurableMiniMRCluster_1335188990
>    -+ ConfigurableMiniMRCluster_1973037511
>    -+ test-dir
>         -+ dfs
>         -+ hadopp-XYZ-01
>         -+ hadopp-XYZ-02 
>         -+ hadopp-XYZ-03
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org

Reply via email to