On Tue, Jun/10/2008 01:20:45PM, Gautam Iyer wrote:
> On Tue, Jun 10, 2008 at 09:55:43PM +0200, cyril Romain wrote:
>
> >> The offending lines look something like this:
> >>
> >> start = PVTS(r, page)->cmdbuf_escstart ?: PVTS(r, page)->cmdbuf_ptr;
> >>
> >> Looks like something is missing between the "?" and ":"?
> >>
> > May be gcc does not complain on other system and implicitly interprets
> > "?:" as "? NULL :".
>
> The info page of gcc on my system says that "a :? b" is the same as "a
> ? NULL : b ". (I think I'm responsible for the above syntax. I learnt my
> programming from the man pages installed on my system, and didn't for a
> moment think that there would be any difference on other unix like
> systems...)
>
> > Could you please try with:
> >
> > start = PVTS(r, page)->cmdbuf_escstart ? NULL : PVTS(r, page)->cmdbuf_ptr;
>
> If it works, feel free to send me a patch for inclusion!
The attached patch gets it passed the "?:" issues. (I didn't
have a real SVN checkout, so I don't know if my "makeshift"
diff will work.)
Thanks,
Ethan
>
> GI
>
> --
> 100 THINGS I'D DO IF I EVER BECAME AN EVIL OVERLORD
> 20. Despite its proven stress-relieving effect, I will not indulge in
> maniacal laughter. When so occupied, it's too easy to miss unexpected
> developments that a more attentive individual could adjust to
> accordingly.
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> Materm-devel mailing list
> Materm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/materm-devel
> mrxvt home page: http://materm.sourceforge.net
Index: src/command.c
1737c1737
< start = PVTS(r, page)->cmdbuf_escstart ? NULL : PVTS(r,
page)->cmdbuf_ptr;
---
> start = PVTS(r, page)->cmdbuf_escstart ?: PVTS(r, page)->cmdbuf_ptr;
4397c4397
< FILE* stream = popen( pipeName ? NULL : r->h->rs[Rs_print_pipe], "w" );
---
> FILE* stream = popen( pipeName ?: r->h->rs[Rs_print_pipe], "w" );
4403c4403
< r->h->rs[Rs_print_pipe] ? NULL : pipeName );
---
> r->h->rs[Rs_print_pipe] ?: pipeName );
Index: src/xdefaults.c
809c809
< const char *name = r->h->rs[Rs_name] ? NULL : APL_NAME;
---
> const char *name = r->h->rs[Rs_name] ?: APL_NAME;
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Materm-devel mailing list
Materm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/materm-devel
mrxvt home page: http://materm.sourceforge.net
