On Tue, Jun/10/2008 02:29:16PM, Gautam Iyer wrote:
> On Tue, Jun 10, 2008 at 04:51:44PM -0400, Ethan Mallove wrote:
>
> > The attached patch gets it passed the "?:" issues. (I didn't have a
> > real SVN checkout, so I don't know if my "makeshift" diff will work.)
>
> It was reversed, but applied fine. In SVN,
>
> Thanks for the patch,
>
> GI
Attached is another (possibly Sun Studio specific) patch.
Sun Studio complains about missing symbols if a few of these
"inline" functions are not "static inline". E.g.,
$ cc -g -I/usr/openwin/include -L/usr/openwin/lib -o mrxvt command.o
encoding.o init.o macros.o main.o menubar.o misc.o netdisp.o pixmap.o ptytty.o
rxvt.o rxvtmem.o screen.o scrollbar.o strings.o tabbar.o transparent.o
xdefaults.o scrollbar-plain.o scrollbar-xterm.o scrollbar-next.o
scrollbar-rxvt.o scrollbar-sgi.o logging.o mjpg.o mpng.o session.o -lpng
-ljpeg -lXpm -lICE -lSM -lX11 -L/usr/openwin/lib -lz -lm
Undefined first referenced
symbol in file
rxvt_clear_area screen.o
rxvt_cmdbuf_has_input command.o
rxvt_fill_rectangle screen.o
ld: fatal: Symbol referencing errors. No output written to mrxvt
Changing them to "static inline" fixes the problem.
-Ethan
>
> --
> Advertisement: "Guitar for sale. Cheap! No strings attached."
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> Materm-devel mailing list
> Materm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/materm-devel
> mrxvt home page: http://materm.sourceforge.net
Index: src/command.c
162c162
< inline int rxvt_cmdbuf_has_input ( rxvt_t *r, int page );
---
> static inline int rxvt_cmdbuf_has_input ( rxvt_t *r, int page );
1640c1640
< inline int
---
> static inline int
Index: src/screen.c
183,184c183,184
< void inline rxvt_clear_area (rxvt_t*, int page, int x, int y, unsigned
int w, unsigned int h);
< void inline rxvt_fill_rectangle (rxvt_t*, int page, int x, int y, unsigned
int w, unsigned int h);
---
> void static inline rxvt_clear_area (rxvt_t*, int page, int x, int y,
> unsigned int w, unsigned int h);
> void static inline rxvt_fill_rectangle (rxvt_t*, int page, int x, int y,
> unsigned int w, unsigned int h);
2743c2743
< void inline
---
> void static inline
2752c2752
< void inline
---
> void static inline
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Materm-devel mailing list
Materm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/materm-devel
mrxvt home page: http://materm.sourceforge.net
