On Mon, Feb 15, 2010 at 5:59 PM, T J <tjhn...@gmail.com> wrote: > On Sun, Feb 14, 2010 at 2:49 PM, T J <tjhn...@gmail.com> wrote: >> I ran across: >> >> http://old.nabble.com/half-filled-markers-td24003576.html >> >> The name "fillstyle" can give the wrong impression about what is being >> filled. For example, see the comment here: >> >> >> http://www.mail-archive.com/matplotlib-users@lists.sourceforge.net/msg13074.html >> >> It's probably too late, but would "markerfillstyle" be a better name for >> this? >> >> Also, the current implementation fills half of the marker with the >> markerfacecolor and doesn't fill the marker at all for the other half. >> I think a neat (and simple) feature would be for users to specify two >> colors. Perhaps 'markerfacecolor2'. The change to the code is >> minimal, but the functionality it brings is quite flexible. >> markerfacecolor2 can default to 'none' to maintain current >> functionality. >> >> Should I file a ticket for this?
>> > > I went ahead and implemented this. The user can now specify > 'markercoloralt'. In the process, I finished the "half-marker" code > for all remaining filled_markers. The diff is attached, which also > includes a fix for bug #560720: > > > https://sourceforge.net/tracker/?func=detail&aid=2952236&group_id=80706&atid=560720 > > Please comment. If there are no comments in a few days, I'll file a ticket. > > A picture demonstrating this functionality is attached. Demos for all > filled markers can be obtained here: > > http://www.filedropper.com/filledmarkers > > Note, the diff contains the script used to generate the pictures. More > generally, I wonder if there should be a 'markerangle' keyword. I can > probably push through and implement this, but I'd like to hear what > people think about it. Very nice and thorough work. I think this should be included, but I'll wait to hear from other developers before committing. Could you confirm that the unit tests pass? >>> import matplotlib >>> matplotlib.test() I think the markerangle would also be a useful contribution, though it would render some of the markers redundant (eg triangle left, right, etc, would all just be triangles with different angles...) Many thanks, JDH ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ Matplotlib-users mailing list Matplotlib-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/matplotlib-users
