> > Hi Mike, folks > > As I mentioned above, the tickless project is replacing the lbolt > variables with two new functions that will deliver the same service in > an event driven way. To update the mdb consumers of lbolt, I've added a > routine to the module API called mdb_get_lbolt() which will return > panic_lbolt if we're examining a core file, or calculate the value of > lbolt if debugging a live system. I've also updated all places in mdb > where the lbolt variable was read to use the new routine. > > Could you please review the design/implementation for these changes ? > I've uploaded a webrev to http://cr.opensolaris.org/~rafaelv/mdb_lbolt/ > > Thanks, > Rafael
The lbolt variable and concept is specific to the kernel. We do not export kernel-specific or target-specific concepts through the module API. This entire thing needs to move into mdb_ks.c, which is where kernel-specific APIs go. Also you can't call native gethrtime: you need to consider kmdb there. (If you look at kmdb_stubs.c you will see this isn't going to do what you think it should) Please send another webrev when you've addressed the above. -Mike -- Mike Shapiro, Sun Microsystems Open Storage / Fishworks. blogs.sun.com/mws/
