ext Arjan van de Ven wrote:
On 4/21/2010 1:12, Roger Quadros wrote:
From: Roger Quadros<[email protected]>

Patch-mainline: 2.6.35?
Git-repo: 
http://www.gitorious.org/linux-omap-dss2/linux/commit/36b33efe80eb07e3447107c2bdba3c674c10a41a

This allows us to disable DPI on systems that do not have it

this does not look like a very pretty patch to me;

+#ifdef CONFIG_OMAP2_DSS_DPI
        dpi_exit();
+#endif

at least, Linux style is to make dpi_*() a noop i the header via one global 
ifdef in the .h,
rather than doing ifdefs all over the code....

Agreed, but I did it this way to maintain consistency with the rest of code drivers/video/omap2/dss/core.c which is already mainline.

We can have a different patch to correct this in entire dss2 core.
_______________________________________________
MeeGo-dev mailing list
[email protected]
http://lists.meego.com/listinfo/meego-dev

Reply via email to