On Mon, Aug 23, 2010 at 07:37:41PM -0700, James wrote:
> On 08/19/2010 05:11 PM, Greg KH wrote:
>> On Thu, Aug 19, 2010 at 04:24:59PM -0700, James wrote:
>>    
>>> This patch modifies cy8ctmg110_touch_pos to map all of the data provided
>>> from the hardware into the cy8ctmg110 data structure for use within the
>>> driver.  In doing so, the patch also cleans up some endian conversions to
>>> use be16_to_cpup()
>>>
>>> This gets the driver one step closer to being able to support multi-touch.
>>>
>>> Signed-off-by: James Ketrenos<jketr...@linux.intel.com>
>>> ---
>>>   drivers/input/touchscreen/cy8ctmg110_ts.c |   80
>>> ++++++++++++++++++----------
>>>   1 files changed, 51 insertions(+), 29 deletions(-)
>>>
>>> diff --git a/drivers/input/touchscreen/cy8ctmg110_ts.c
>>> b/drivers/input/touchscreen/cy8ctmg110_ts.c
>>> index c1677f9..1337371 100644
>>> --- a/drivers/input/touchscreen/cy8ctmg110_ts.c
>>> +++ b/drivers/input/touchscreen/cy8ctmg110_ts.c
>>> @@ -57,6 +57,7 @@
>>>
>>>   #define CY8CTMG110_POLL_TIMER_DELAY    (1000*1000*100)
>>>   #define TOUCH_MAX_I2C_FAILS        50
>>> +#define MAX_FINGERS            2
>>>      
>> Why just 2?  What's wrong with 4?  Or 8?  Or some other number?
>>    
> The hardware only supports tracking of 2 contact points.

Then you might want to state that somewhere :)

thanks,

greg k-h
_______________________________________________
MeeGo-dev mailing list
MeeGo-dev@meego.com
http://lists.meego.com/listinfo/meego-dev

Reply via email to