On Thu, Aug 19, 2010 at 04:28:39PM -0700, James wrote: > This patch optionally provides a mode of multitouch that works with > Qt 4.7's approach of taking input from multiple /dev/input/event > interfaces. It does so by creating one input device for each supported > contact point (2 in this case) > > If there is another way to create mulitiple event interfaces on > a single input device, please point me to them. > > Once the new multi-touch protocol is supported up the entire vertical > stack, I expect this would shift to support that mechanism of exposing > multitouch data. > > The above is enabled via CONFIG_TOUCHSCREEN_CY8CTMG110_MULTIPLE_INPUT > with the default set to 'Y' (to enable current Qt 4.7 based applications > to leverage this capability) > > Signed-off-by: James Ketrenos <jketr...@linux.intel.com> > --- > drivers/input/touchscreen/Kconfig | 13 +++++ > drivers/input/touchscreen/cy8ctmg110_ts.c | 76 > +++++++++++++++++++++++++++-- > 2 files changed, 85 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/Kconfig > b/drivers/input/touchscreen/Kconfig > index 6f08b10..a103384 100644 > --- a/drivers/input/touchscreen/Kconfig > +++ b/drivers/input/touchscreen/Kconfig > @@ -615,6 +615,19 @@ config TOUCHSCREEN_CY8CTMG110 > To compile this driver as a module, choose M here: the > module will be called cy8ctmg110_ts. > > +config TOUCHSCREEN_CY8CTMG110_MULTIPLE_INPUT > + bool "cy8ctmg110 multiple interface support" > + default y
If it's default y, why even have a config option? And note, we don't do default y for new config options, unless you can't boot your machine without it. > --- a/drivers/input/touchscreen/cy8ctmg110_ts.c > +++ b/drivers/input/touchscreen/cy8ctmg110_ts.c > @@ -81,8 +81,13 @@ struct ts_event { > * The touch driver structure. > */ > struct cy8ctmg110 { > +#ifdef CONFIG_TOUCHSCREEN_CY8CTMG110_MULTIPLE_INPUT > + struct input_dev *input[MAX_FINGERS]; > + char phys[MAX_FINGERS][32]; > +#else > struct input_dev *input; > char phys[32]; > +#endif No #ifdefs in .c files please. And your email client messed up the tabs in the patch, please fix that before submitting again. thanks, greg k-h _______________________________________________ MeeGo-dev mailing list MeeGo-dev@meego.com http://lists.meego.com/listinfo/meego-dev