Hello,

On Wed, 15 Sep 2010, ext stefano.mosc...@nokia.com wrote:
> I'd suggest that if you haven't done so already, you open a bug in 
> bugs.meego.com under 'general' 'general requests' and continue the discussion 
> there.
> 
> Imho gitorious review control is tight to the version control system you use 
> (git in this case) and it's not good (actually not usable) for instance for 
> those who use mercurial.

Yes.  Those who use Hg could use something which is integrated with
Mercurial.

> So I'd personally prefer something which can interact with all the VCSs out 
> there in some automagic way.
> Reviewboard works with hg, git and svn, AFAICR.

It is like a swiss knife.  Is it good?  Yes?  Is it better than
dedicated tool (in our case, the tool which is heavily integrated with
git or bugzilla)?  For sure, it is much worse.

You look from the IT infrastructure costs PoV :-)  Of course, it is
simpler to maintain just one tool.  But in this case it is simpler to
drop the support for Hg and promote the "Git is "ueber alles"
principle).  And have review system from gitorious there :-)

> 
> -- 
> Stefano
> Sent from N900
> ----- Messaggio originale -----
> > On 09/14/2010 09:28 AM, Vitaly Repin wrote:
> > > BTW, don't forget about gitorious code review feature:
> > http://blog.gitorious.org/2009/11/06/awesome-code-review/
> > 
> > I don't like it for a few reasons:
> > 
> > - The code is not showed with a monospaced font, so it's nearly
> > impossible to 
> > check the indentation
> > 
> > - Inline commenting sometimes does not work: you click on one line
> > number and 
> > nothing happens
> > 
> > - You only see the diff; reviewboard instead provides a clickable link
> > which 
> > expands showing also the unchanged code
> > 
> > - I never get any notification when someone adds a comment
> > 
> > Ciao,
> >        Alberto
> > 
> > -- 
> > http://blog.mardy.it <-- geek in un lingua international!
> > _______________________________________________
> > MeeGo-dev mailing list
> > MeeGo-dev@meego.com
> > http://lists.meego.com/listinfo/meego-dev
> > 
> _______________________________________________
> MeeGo-dev mailing list
> MeeGo-dev@meego.com
> http://lists.meego.com/listinfo/meego-dev

-- 
WBR & WBW,
Vitaly Repin,
Productivity, Nokia-D
_______________________________________________
MeeGo-dev mailing list
MeeGo-dev@meego.com
http://lists.meego.com/listinfo/meego-dev

Reply via email to