marmoute added inline comments.

INLINE COMMENTS

> martinvonz wrote in commands.py:2339
> If you first do `hg cp a b`, you can't then do `hg cp --forget a`, it needs 
> to be the destination. The "SOURCE" and "DEST" names refer to the names in 
> the synopsis. I was trying to clarify that that they're treated the same, but 
> maybe there will be no confusion and I should not mention it?

doing `hg cp a b` does not add copies information to `a`, so I don't think 
there would be confusion from the users.

What I find the most confusing part is the piece refering to `SOURCE` and 
`DEST` for an operation that as no such pair. I would refer to an explicite 
`TARGET` argument and include some kind of synopsys (at that location in the 
documentation)

> martinvonz wrote in test-copy.t:304
> I'll leave that for a follow-up. I don't think it should be a requirement.

Okay that seems fair. Do you think you could impletement that before 5.4 ?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8029/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8029

To: martinvonz, #hg-reviewers, durin42, marmoute
Cc: pulkit, durin42, marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to