martinvonz added inline comments.

INLINE COMMENTS

> marmoute wrote in commands.py:2339
> The other command with variable number of arguments I can think of usually 
> mark them as optional in their synopsis (eg: `hg bookmarks`), but I feel like 
> the situation in a bit different.
> 
> The new doc is clearer, but still not very clear. Can you try adding the 
> synopsis to see how it looks like?
> 
> An alternative is to augment the help test to support multiple synopsys, "it 
> can't be that hard".

I'll let other reviewers decide if it's worth blocking the patch or series for 
that. I think it's quite clear already.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8029/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8029

To: martinvonz, #hg-reviewers, durin42, marmoute
Cc: pulkit, durin42, marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to