FWIW, I think this is a worthwhile interface cleanup. Your commit comment says it all.
I did think of this when introducing the current shader caps enums, but informal feedback I got was that it was better to stick with the current get_param system. Now that the number of shader types is growing perhaps this becomes more appealing to everyone. Jose On Sun, 2010-09-05 at 18:30 -0700, Luca Barbieri wrote: > Currently each shader cap has FS and VS versions. > > However, we want a version of them for geometry, tessellation control, > and tessellation evaluation shaders, and want to be able to easily > query a given cap type for a given shader stage. > > Since having 5 duplicates of each shader cap is unmanageable, add > a new get_shader_param function that takes both a shader cap from a > new enum and a shader stage. > > Drivers with non-unified shaders will first switch on the shader > and, within each case, switch on the cap. > > Drivers with unified shaders instead first check whether the shader > is supported, and then switch on the cap. > > MAX_CONST_BUFFERS is now per-stage. > The geometry shader cap is removed in favor of checking whether the > limit of geometry shader instructions is greater than 0, which is also > used for tessellation shaders. > > WARNING: all drivers changed and compiled but only nvfx tested _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
