Hi Aapo,

[...]

> Commited.
> I found couple problems with fog patch:
> -fog didnt get disabled when doing buffer clears
> -when enabling fog, fog state needs to be updated since r300Fogfv returns
> -gb_select was already part of gb_misc

Thanks for fixing it. :)

It works fine, except for a small problem of recursively calling r300Enable() 
(see patch).

bye,

Ewald
--- Mesa/src/mesa/drivers/dri/r300/r300_state.c.orig	2006-04-11 08:25:59.000000000 +0200
+++ Mesa/src/mesa/drivers/dri/r300/r300_state.c	2006-04-11 09:04:59.000000000 +0200
@@ -423,7 +423,6 @@
 			r300->hw.fogs.cmd[R300_FOGS_STATE] |=
 			    R300_FOG_ENABLE;
 			
-			r300Enable(ctx, GL_FOG, ctx->Fog.Enabled);
 			ctx->Driver.Fogfv( ctx, GL_FOG_MODE, NULL );
 			ctx->Driver.Fogfv( ctx, GL_FOG_DENSITY, &ctx->Fog.Density );
 			ctx->Driver.Fogfv( ctx, GL_FOG_START, &ctx->Fog.Start );

Reply via email to