On Fri, 2006-09-22 at 10:58 +0100, Keith Whitwell wrote:
> Michel Dänzer wrote:
> > On Fri, 2006-09-22 at 10:41 +0100, Keith Whitwell wrote:
> >> Michel Dänzer wrote:
> >>
> >>> - if (dstFormat == &_mesa_texformat_argb8888) {
> >>> + if (!littleEndian || dstFormat == &_mesa_texformat_argb8888) {
> >> In cases like this, wouldn't you want the exclusive or of the two
> >> values, ie
> >>
> >> ((littleEndian && dstFormat == &_mesa_texformat_argb8888) ||
> >> (!littleEndian && dstFormat == &_mesa_texformat_argb8888_rev))
> >>
> >> I don't think it makes sense otherwise - you'll always end up using one
> >> translation regardless of the texformat.
> >
> > Right, thanks. How about this?
>
> Wouldn't it be necessary to do similar byte-swapping for all the other
> texture formats that the swizzle path is being activated on?
Tried that (via byte swapping as an added first mapping in
_mesa_swizzle_ubyte_image()), glean breaks. I don't understand why it's
needed in this case but not the others though.
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
