Westermann Fu wrote: > Dear All: > > I have a doubt about precondition of > _mesa_adjust_image_for_convolution() usage.The current version of Mesa > core I was reading is 7.0.3 > > In _mesa_TexImage2D, we will call _mesa_adjust_image_for_convolution() > to caculate postConvWidth and postConvHeight to pass to > _mesa_init_teximage_fields() if and only if the condition > is_color_format(internalformat) satisfied, but after a while, when > we call into the default driver->TexImage2D() which always is > _mesa_store_teximage2d(), we will find that only if the > IMAGE_CONVOLUTION_BIT bit is set in ctx->_ImageTransferState field, we > will caculate postConvWidth and postConvHeight via > _mesa_adjust_image_for_convolution() function, then use the > postConv* width and height to caculate the buffer size. I think that the > two on and on _mesa_adjust_image_for_convolution() calling path are not > consistency, the texImage->Width2 and texImage->Heigth2 will be not > consistency with allocated texture buffer size yet. > > Anybody can point for me what's wrong in my understanding? Thanks very much!
You're correct that the test/predicate for _mesa_adjust_image_for_convolution() is inconsistant in those two places. I'm checking in a fix now. I think it would have only mattered if convolution was enabled and the tex image was a depth or index format. -Brian ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
