Westermann Fu wrote:
> Hi:
>
> I'm the topic starter of "*is_color_format() and convolution
> calculation*", because some reasons I dropped my original mail address
> of hotmail, instead, I use gmail which I think more suitable here.
>
> First, thanks for Brian's quick reply, then, I totally agree with you.
> In function of _mesa_store_teximage_{1,2}d(), I found that the
> "postConvWidth" and "postConvHeight" used for caculating buffer size but
> the dstRowStride is caculated via texImage->RowStride! It means in this
> function we can assume that the texImage object is valid yet, so its
> Width, Height, Width2, Height2... should also be valid too. So why not
> drop off _mesa_adjust_image_for_convolution() here and directly use
> texImage->Width and texImage->Height for buffer size caculation? Below
> is my patch for this function, some problems please point to for me,
> thanks very much. The mesa version is 7.0.3. <http://7.0.3.>
Yes, we can make this change. The intention of doing it that way was to
reinforce to the reader that the width/height parameters may be
pre-convolution sizes and not the actual texture size.
I see there's some comments about this already though so there really
shouldn't be any confusion.
-Brian
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
