Hi Michel: I've added your patch (slightly modified to work with mesa_7_4_branch), but it still doesn't help. Attached is:
1) the modified patch I used (so you can see), radeon_test2.patch 2) the glxinfo with the combination of the existing radeon patch in mesa_7_4_branch and your new patch, glxinfo.broken 3) the glxinfo with solely my patch applied, glxinfo.working Regards 2009/4/17 Mario Limonciello <supe...@ubuntu.com> > Hi Michel: > > 2009/4/17 Michel Dänzer <mic...@daenzer.net> > >> >> I don't think this makes sense, in particular, I don't think >> radeonFillInModes() can really handle the 8 and 24 cases. >> >> Git master (e798bf8053612516420a4ec42e2ff58433abd521) and >> mesa_7_4_branch (775ca8e3fa5ddf090115907c78889ed8311cd3ae) already have >> a change which I suspect will help for your problem, can you try it? If >> it doesn't help, please try the patch below which I've been testing on >> top of that. If that still doesn't help, please provide glxinfo output >> from these patches and your patch. >> > I've tried the existing commit in mesa_7_4_branch before writing my patch, > but it didn't appear to help the situation. I'll report back how this > additional patch below does after I get a chance to build it. > > Regards > > > -- > Mario Limonciello > supe...@gmail.com > Sent from Austin, TX, United States -- Mario Limonciello supe...@gmail.com
glxinfo.broken
Description: Binary data
glxinfo.working
Description: Binary data
--- a/src/mesa/drivers/dri/radeon/radeon_screen.c 2009-04-17 20:04:43.000000000 -0500
+++ b/src/mesa/drivers/dri/radeon/radeon_screen.c 2009-04-17 20:06:34.000000000 -0500
@@ -255,6 +255,8 @@
unsigned pixel_bits, unsigned depth_bits,
unsigned stencil_bits, GLboolean have_back_buffer )
{
+ __DRIconfig **configs_a8r8g8b8;
+ __DRIconfig **configs_r5g6b5;
__DRIconfig **configs;
__GLcontextModes *m;
unsigned depth_buffer_factor;
@@ -287,23 +289,20 @@
depth_buffer_factor = ((depth_bits != 0) || (stencil_bits != 0)) ? 2 : 1;
back_buffer_factor = (have_back_buffer) ? 2 : 1;
- if (pixel_bits == 16) {
- __DRIconfig **configs_a8r8g8b8;
- __DRIconfig **configs_r5g6b5;
-
- configs_r5g6b5 = driCreateConfigs(GL_RGB, GL_UNSIGNED_SHORT_5_6_5,
- depth_bits_array, stencil_bits_array,
- depth_buffer_factor, back_buffer_modes,
- back_buffer_factor);
- configs_a8r8g8b8 = driCreateConfigs(GL_BGRA, GL_UNSIGNED_INT_8_8_8_8_REV,
- depth_bits_array, stencil_bits_array,
- 1, back_buffer_modes, 1);
- configs = driConcatConfigs(configs_r5g6b5, configs_a8r8g8b8);
- } else
- configs = driCreateConfigs(GL_BGRA, GL_UNSIGNED_INT_8_8_8_8_REV,
- depth_bits_array, stencil_bits_array,
- depth_buffer_factor,
- back_buffer_modes, back_buffer_factor);
+ configs_r5g6b5 = driCreateConfigs(GL_RGB, GL_UNSIGNED_SHORT_5_6_5,
+ depth_bits_array, stencil_bits_array,
+ depth_buffer_factor, back_buffer_modes,
+ back_buffer_factor);
+ configs_a8r8g8b8 = driCreateConfigs(GL_BGRA, GL_UNSIGNED_INT_8_8_8_8_REV,
+ depth_bits_array, stencil_bits_array,
+ depth_buffer_factor,
+ back_buffer_modes, back_buffer_factor);
+
+ if (pixel_bits == 16)
+ configs = driConcatConfigs(configs_r5g6b5, configs_a8r8g8b8);
+ else
+ configs = driConcatConfigs(configs_a8r8g8b8, configs_r5g6b5);
+
if (configs == NULL) {
fprintf( stderr, "[%s:%u] Error creating FBConfig!\n",
------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p
_______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
