On Wed, May 20, 2009 at 4:20 PM, Carl Worth <[email protected]> wrote: > The rationale here is to avoid updating a timestamp for a file that > hasn't changed. Needless updates of the timestamp can ripple into > other projects, (xserver, etc.), useless recompiling due to a > 'make install' in mesa that didn't actually change anything.
Is this because the timestamps of the headers change? Don't all build tools (probably using /usr/bin/install) update timestamps when installing? > --- > bin/minstall | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/bin/minstall b/bin/minstall > index 8ee9608..1300258 100755 > --- a/bin/minstall > +++ b/bin/minstall > @@ -66,8 +66,11 @@ if [ $# -ge 2 ] ; then > > elif [ -f "$FILE" ] ; then > #echo "$FILE" is a regular file > - $RM "$DEST/`basename $FILE`" > - cp "$FILE" "$DEST" > + # Only copy if the files differ > + if ! cmp -s $FILE $DEST/`basename $FILE`; then > + $RM "$DEST/`basename $FILE`" > + cp "$FILE" "$DEST" > + fi There's nothing technically wrong with this, but I don't see why mesa needs to be different than, say, automake. This also fails to take into account a user not having cmp. It's a slim chance, but it wasn't previously a prereq. -- Dan ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
