On Thu, 2009-05-21 at 14:27 -0700, Dan Nicholson wrote:

> Actually, to be fair, if you didn't have cmp, the test would fail with
> some error message and then copy the file as if cmp exited
> unsuccessfully (the files differed). So, there's actually no
> regression, but we may want to redirect errors.

Ah, good point. I actually wrote the patch with redirecting at first,
but then noticed "cmp -s" and took it back out. I didn't think of this
case though.

> Let's keep this patch for now, but maybe we can clean up the whole
> interaction. install can be used as a drop-in for minstall except for
> the case of copying symlinks, which happens when installing the shared
> library symlinks. I'll see if I can't make that happen at some point
> and ping you to see if it works the way you expect.

Right. It seems like it would be easy enough to do the symlink check
first and then defer to install after that. Anyway, I'll be glad to test
anything. (I subscribed to mesa3d-dev to be able to post, but then I
turned off delivery, so be sure to CC me if you post something you want
me to try.)

-Carl

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to