On Thu, May 21, 2009 at 2:00 PM, Carl Worth <[email protected]> wrote:
> On Thu, 2009-05-21 at 11:19 -0700, Dan Nicholson wrote:
>> Is this because the timestamps of the headers change? Don't all build
>> tools (probably using /usr/bin/install) update timestamps when
>> installing?
>
> Most build tools allow the user to install a custom install with, for
> example:
>
>        INSTALL=${HOME}/bin/install-check
>
> where install-check could be a tiny program that does the comparison,
> then conditionally calls /usr/bin/install.

Oh, I see. You can actually override $(INSTALL) if you want. The
default is $(SHELL) $(TOP)/bin/minstall. However, you're custom
install would have to support copying symlinks (like cp -P).

>> There's nothing technically wrong with this, but I don't see why mesa
>> needs to be different than, say, automake. This also fails to take
>> into account a user not having cmp. It's a slim chance, but it wasn't
>> previously a prereq.
>
> Right. I almost mentioned this explicitly in the commit message. For my
> setup here, I am having to do something special to mesa that I don't do
> with any automake-using packages. But that's because mesa is shipping
> with its own install script, (and not respecting an INSTALL variable).

Actually, to be fair, if you didn't have cmp, the test would fail with
some error message and then copy the file as if cmp exited
unsuccessfully (the files differed). So, there's actually no
regression, but we may want to redirect errors.

> It would be perfectly valid to instead fix minstall to call out
> to /usr/bin/install when possible, (and to also respect the INSTALL
> variable). That would also allow me to get the behavior I want, (and in
> a way that's standard across many packages).

Let's keep this patch for now, but maybe we can clean up the whole
interaction. install can be used as a drop-in for minstall except for
the case of copying symlinks, which happens when installing the shared
library symlinks. I'll see if I can't make that happen at some point
and ping you to see if it works the way you expect.

--
Dan

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

Reply via email to