On Fri, 2009-08-14 at 06:50 -0700, Chia-I Wu wrote: > Hi, > > This patch series aims to remove eglhash.c and eglhash.h. Consider the > speed of eglHashTable in its current form, and that there are usually > only a small number of displays/surfaces/contexts, it should be faster > to simply use lists. It also gives cleaner code. > > It depends on the last two patch series I sent earlier today. One of > them is too large (because of lots of s/xxx/yyy/) and is moderated > though. You might see this patch series first. > > The first two patches removes hash tables from surface lookup and > display lookup respectively (context does not use a hash table since > beginning). Lists are used to chain displays, contexts, and surfaces. > And a _EGLDisplay or _EGLSurface is directly casted to a EGLDisplay or > EGLSurface. > > The third patch makes lookup functions static inline, and the fourth > patch adds back handle checking. The checks are done by traversing the > lists, and can be disabled at compile time. > > The following patch removes eglhash.[ch]. And the last patch fixes a > compilation error of progs/egl/demo3, which uses an internal function of > EGL core directly. Please help review. >
Chia, Regarding 0006-progs-egl-Fix-compilation-error-of-demo3.patch: In general it is preferable not to introduce compilation errors into the git history, at least knowingly. Can you respin your patch series to not introduce the error in the first place? I think I saw this in a previous series from you, that compilation broke in one patch & was fixed in a subsequent one in the series. That's a pain later on if someone tries to bisect & lands at your broken patch... Keith ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
