Michal, It's really not the job of the shader representation to do this type of versioning between halves of a driver. If we ever get to a point where we want to do versioning in gallium, we'll want the version control to cover the entire interface, not just the shaders.
Given that, and given we won't want to have >1 version of TGSI active within a particular version of gallium, there's no purpose for separate versioning of the shader token stream -- it's just one aspect of the total interface. If we want to do such a sanity check, it should be done at context or screen creation - well before we ever get around to creating shaders. So I still don't see any point in a shader version token. The fact that TGSI has been through dramatic changes in its lifetime and still advertises itself as 1.1 illustrates this - it's redundant currently and I don't see any use for it in the future either... Keith ________________________________________ From: michal [mic...@vmware.com] Sent: Thursday, November 26, 2009 11:10 AM To: Keith Whitwell Cc: mesa3d-dev@lists.sourceforge.net Subject: Re: [Mesa3d-dev] TGSI simplification branch > I don't see that as an issue. First and foremost, TGSI is part of > gallium, which itself makes no binary compatibility guarantees from one > build to the next. In terms of tracing and replay, or any other use of > TGSI to communicate shaders between components that weren't necessarily > built at the same time, then yes a version number would be nice. But > those shaders won't exist in isolation and the rest of the 3d commands & > state will need to establish compatibility. > > It's not the job of the shader representation to do versioning between > two gallium-speaking entities. > > >From that point of view I'm really not sure what the purpose of the > version number, is in our representation, unless we want to be able to > support multiple versions of TGSI simultaneously in one gallium > instance. > > And in turn, I can't really think why we'd want to do that... > > So -- lets remove the version token while we're here. > > One scenario is a sanity check done in the gallium driver. Check if version number matches (exact match) -- there can be changes in the interface that do not break builds. No fancy major.minor versioning schemes, just a number incremented each time we change something in p_shader_tokens. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
